'You must sign in to comment' link is not visible to users to click on #171

QuantEcon / Bookshelf

Code for the site QuantEconLib

1 stars 0 forks source link

'You must sign in to comment' link is not visible to users to click on #171 #323

Closed AtlasMaxima-zz closed 5 years ago

AtlasMaxima-zz commented 5 years ago

Add modal pop up when users try to comment without being signed in and well ask users to cancel or sign in and redirects user to sign in page if they want to sign in to make a comment to the submission.

AakashGfude commented 5 years ago

Hi @AtlasMaxima Nice work. There can be addition to this feature. When a person types his comment and then presses submit. At present, it logs in the user, but the typed comment is lost. We can save it somewhere, possibly local storage for it to persist. And redirect the user to the same comment page after log in.

AtlasMaxima-zz commented 5 years ago

@mmcky @AakashGfude This PR has satisfied the following criteria and is currently running on the development site:

[x] Modal window with cancel and sign in options if user is currently not logged in.
[x] Redirect user to sign in page.
[x] Cancel modal window if user presses cancel.
[x] Persistent previous comment before and after logging in.
[x] Redirect user back to previous comment page after logging in.
[ ] Previous comment must only persist according to the comment id.

AakashGfude commented 5 years ago

Hi @AtlasMaxima , I am having the following issues at present in the development site :-

1) not redirecting to the previous comment page after logging in. 2) the comment is persistent, but it appears on all the posts comment page (not only in the intended post)

AtlasMaxima-zz commented 5 years ago

@AakashGfude that's strange because it redirects on https://development-notes.quantecon.org/ for me back to the previous comment page after logging in.

Can you take a screenshot on what you mean by comment persists on all the posts comment page.

AakashGfude commented 5 years ago

Hi @AtlasMaxima , after I signed it redirects me to :-

screenshot from 2019-02-22 13-45-45

By comment persists on all the posts comment page i mean that the comment which I typed for some post is visible in all the post's comment page. Example I typed comment for this submission

screenshot from 2019-02-22 13-46-17

But it is also visible in this submission's comment page :-

screenshot from 2019-02-22 13-46-54

AakashGfude commented 5 years ago

Hey @AtlasMaxima, the code where you redirect to the comment page after signing in, i think it should also be done for new users as well. So, in the code section shown in the screenshot below, allow the same redirect and check also in the case of isNew

AtlasMaxima-zz commented 5 years ago

resolved through search-conflict branch