search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

Social media and self-emailing buttons #333

Open AtlasMaxima-zz opened 5 years ago

AtlasMaxima-zz commented 5 years ago

@mmcky @AakashGfude @natashawatkins @jstac If user signs in using Twitter, there appears to be the Twitter button in their profile and if user clicks on it, it will redirect the user to their Twitter profile.

screen shot 2019-02-19 at 10 54 03 pm

If user signs in using Github, there appears to be the Github button and an email button.

screen shot 2019-02-19 at 11 00 55 pm

However, if the user signs in using Google, there are no such buttons.

screen shot 2019-02-19 at 10 58 59 pm

Not sure what the email button is for via Github sign in. It just opens up the default email application on your computer. Do we want to keep this and have this option for Google and Twitter as well or remove it?

Do we want to have a Google button where it redirects user to their Google account like how it is using Github and Twitter sign in?

AakashGfude commented 5 years ago

@AtlasMaxima I think it would be better to not link the google profile as Google + is shutting down on April https://plus.google.com/+googleplus/posts/6d6yqVBmgw9

That email button is mysterious. Not sure why we are self mailing ourselves. Maybe intended to mail the notebook? @DrDrij @mmcky can help us get clarification.

Also, we should direct users to twitter or github in a new tab, instead of taking them away from our site. It is a small fix, will add it in one of my commits.

DrDrij commented 5 years ago

The email button is handy if someone wants to email the author directly.

My only concern is we are publishing the author's email without asking for their consent. There is a risk that bots could pickup the email for spamming.

I realise building a messaging system is out of scope at this point and a fair bit of work.

One potential solution could be email via the site. Meaning a visitor can email the author but never has access to their email. This could potentially be achieved a bit more simply with a modal/popup or additional page which appears when clicking the email button. A user can enter a message and the message is emailed to the author from QE Notes.

From: QE Notes Subject: User message Body: Dear , you have received the following message from user . ...

While typing this I realise that for the author to reply will need to know who it's from and a reply address (user would need to be logged in). Again to simplify, we could have a line of text in the modal/popup such as... "Please add your contact details for the author to respond to your message".

However, I'd probably still suggest this email button only works if a user is logged in, otherwise redirecting to sign in page. Further eliminating changes of miss-use.

Thoughts? :)