search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

separated python script for config #361

Closed AtlasMaxima-zz closed 4 years ago

AtlasMaxima-zz commented 4 years ago

separated out the python config script into smaller modules and added exception handlings for write and open files.

mmcky commented 4 years ago

thanks @AtlasMaxima. When this is ready for review can you ping @AakashGfude and me.

AtlasMaxima-zz commented 4 years ago

this has been tested within the dev environment just then and it works fine.

AakashGfude commented 4 years ago

Thanks @AtlasMaxima , while you are at it, can you also remove conflicts committed in this file? https://github.com/QuantEcon/Bookshelf/blob/dev/fix-config-python-script/scripts/dev-config.sh . Looks like it has been there for a while. Also, it is better to not commit .pyc files. A good explanation is given here https://coderwall.com/p/wrxwog/why-not-to-commit-pyc-files-into-git-and-how-to-fix-if-you-already-did

AtlasMaxima-zz commented 4 years ago

Let's create another ticket for the first point so it doesn't impact the scope of this particular ticket. and I'll remove the .pyc