search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

FIX: Sorting to use `Date` by default #364

Closed AakashGfude closed 2 years ago

AakashGfude commented 2 years ago

fixes https://github.com/QuantEcon/Bookshelf/issues/363

jstac commented 2 years ago

Many thanks @AakashGfude . I'll leave it for you and @mmcky to review and merge.

mmcky commented 2 years ago

thanks @AakashGfude

Do we need to figure out credentials or are you able to merge and push this change?

Does this application need to be built -- It has been in so long I wonder if there will be any compilation issues. Is there a way to test this before deployment?

mmcky commented 2 years ago

@AakashGfude is there an order that needs to be specified (i.e. will this be most recent to least recent)

AakashGfude commented 2 years ago

@mmcky yes it will be most recent to least recent. Since this change only targets the front-end API calls, so hopefully should be less prone to compilation issues. I will look for the deployment credentials. I am setting up the system in my present machine as well, for future purposes. Will merge this after testing properly

mmcky commented 2 years ago

@AakashGfude looks like I have shared the certificate for notes.quantecon.org with you via lastpass