Closed oyamad closed 8 years ago
@spencerlyon2 @zaccranko Is there any chance either of you could help @oyamad get the two problematic Julia notebooks (see comments above) fixed up?
@jstac Would you be happy to merge these excellent notebooks into master and then add an issue to track the two problematic Julia notebooks fixed up. (Or we could pull those two notebooks out in a separate PR - so that they aren't sitting on master?)
@mmcky Good idea. I would be happy to merge them into master and put issues in the issue tracker. When we build the front page for the notebooks we can omit the problematic ones from the list until the issues are resolved.
In ddp_ex_job_search_jl.ipynb
, I set the tolerance to some not so small value for fzero
from Roots.jl
(in cell [9]
). I think the speed is acceptable now.
Review is still appreciated.
@jstac Sorry, just caught this message today. Yep, happy to help out. I'll take a look at ddp_theory_jl.ipynb
tomorrow.
All - I am merging this branch to get the majority of notebooks on master.
Then I will pull out the following notebooks into a separate PR to track their updates.
ddp_theory_jl.ipynb [Help needed] I don't know how to set the column names and the row indices of the DataFrame table.
ddp_ex_job_search_jl.ipynb [Review needed] Very slow. Maybe type declarations are not appropriate?
@mmcky Thanks!
Deleted the branch mdp
in QuantEcon.site
.
@ZacCranko @oyamad do we still need someone to take a look at these 2 notebooks?
I just finished a big chunk of what I planned on finishing before Christmas and might have some time to do some review tomorrow.
Notebooks on
DiscreteDP
:I don't know how to set the column names and the row indices of the
DataFrame
table.Job search Alternative implementation for the lecture on job search using
DiscreteDP
.Very slow.Maybe type declarations are not appropriate?Some issues: see QuantEcon/QuantEcon.applications#14.(Resolved)DiscreteDP
.One of the figures looks different from the original one; see https://github.com/QuantEcon/QuantEcon.py/issues/185#issuecomment-153020375.
Please feel free to edit any of the notebooks.