Adding translation into Julia of the Wald Friedman Python notebook

QuantEcon / QuantEcon.notebooks

Jupyter notebooks contributed by QuantEcon developers, users and the community

BSD 3-Clause "New" or "Revised" License

122 stars 105 forks source link

Adding translation into Julia of the Wald Friedman Python notebook #51

Closed albep closed 7 years ago

albep commented 7 years ago

This PR translates into Julia the Python notebook https://github.com/albep/QuantEcon.notebooks/blob/master/Wald_Friedman.ipynb, with some small changes to the text in order ensure consistency with the absence of sliders and the use of Julia types and methods

cc7768 commented 7 years ago

Some comments:

Typically in Julia docstrings go before a function definition instead of after -- See this example
- Since everything here is 1-D, it might be more readable if you use the 1-D interpolation that we have in QuantEcon.jl. See here and here

Otherwise I think this looks really nice. @thomassargent30, do you have any comments?

albep commented 7 years ago

@cc7768 thanks for the comments. I addressed both of them in the latest commit

cc7768 commented 7 years ago

Perfect. I think this looks ready to go. @jstac, I think this is ready to merge. I would let it sit for the rest of the day to see if anyone else has comments, but otherwise I think it is ready.

jstac commented 7 years ago

Thanks all. This is very nice. Merging.