QuantEcon / QuantEcon.py

A community based Python library for quantitative economics
https://quantecon.org/quantecon-py/
MIT License
1.95k stars 2.25k forks source link

MAINT: Fix OMP warning coming from numba #730

Open kp992 opened 3 months ago

kp992 commented 3 months ago

Fixes #627 Fixes #729

I have tested locally and with the current main and pip install ., I get:

% python
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:41:52) [Clang 15.0.7 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import quantecon
OMP: Info #276: omp_set_nested routine deprecated, please use omp_set_max_active_levels instead.

On this branch:

% python       
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:41:52) [Clang 15.0.7 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import quantecon
>>>
pep8speaks commented 3 months ago

Hello @kp992! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-06-10 01:30:40 UTC
kp992 commented 3 months ago

@mmcky Please check if this looks good to you.

kp992 commented 3 months ago

Seems like CI needs fixing. Opened #731.

coveralls commented 3 months ago

Coverage Status

coverage: 93.043% (+0.002%) from 93.041% when pulling 79b9f637fe0c688a4bbd10b8fbdee642e458349a on kp992:i-627 into bea82952f7468733902eff16757fa2430f87250b on QuantEcon:main.

oyamad commented 3 months ago

Thanks for taking care of this issue, but I think I am against changing the user's global setting in a library. What do you guys think?

mmcky commented 3 months ago

thanks @oyamad just diving into this myself.

I agree with @oyamad -- it is not generally a good idea to change global settings for users due to a package import. Is this controllable through checking numba versions and issuing a helpful message for switching it off? Is numba going to fix this warning message?

oyamad commented 3 months ago

There is an open PR numba/numba#7705; I don't know what its current status is (it has not been merged).