Open kp992 opened 3 months ago
Hello @kp992! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
@mmcky Please check if this looks good to you.
Seems like CI needs fixing. Opened #731.
Thanks for taking care of this issue, but I think I am against changing the user's global setting in a library. What do you guys think?
thanks @oyamad just diving into this myself.
I agree with @oyamad -- it is not generally a good idea to change global settings for users due to a package import. Is this controllable through checking numba versions and issuing a helpful message for switching it off? Is numba
going to fix this warning message?
There is an open PR numba/numba#7705; I don't know what its current status is (it has not been merged).
Fixes #627 Fixes #729
I have tested locally and with the current
main
andpip install .
, I get:On this branch: