Closed arnavs closed 5 years ago
@chiyahn I still want to give this another look, but wanted to post so as to avoid a bottleneck. If you think we are good, then when I'm done, we can push and retag.
Merging #121 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #121 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 108 108
=====================================
Hits 108 108
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8da91e4...e150fa9. Read the comment docs.
Codes look good to me. One more thing: you need to update the resulting plot as well (as implementation has slightly changed.)
Roger. You mean this bit? plot(x, v, lw = 4, label = "v")
I think this OK, since v
is evaluated on the interior nodes x
, right? But feel free to push to this branch with fixes and merge whenever you think we're good.
No, I mean the implementation for $L_2$ is different so that the resulting plot for v
is going to be different in the new version as well.
I'll push the new plots
Oh, I see. You're including a static image. OK, will do.
Edit: Thanks, will let you push.
We should probably also change this text, but I'll defer to you on that:
One can alternatively use differential operators on interior nodes and stack them with matrices for boundary conditions to compute
v
:
Since we're still passing in x\bar
.
Oh, actually nevermind for plots. I can confirm that they return the same plots since it's being computed from extension operators rather than operators on interior nodes with bc.
We should probably also change this text, but I'll defer to you on that:
One can alternatively use differential operators on interior nodes and stack them with matrices for boundary conditions to compute v:
Since we're still passing in x\bar.
I agree, I'll make a fix and merge the PR
Thanks @chiyahn, will leave this in your hands then.
PR to fix mistakes in documentation.
README.md
and individual docstrings are fine, so we just needed to patch the examples onindex.md
of the docs website.