search

QuantEcon / SimpleDifferentialOperators.jl

Library for simple upwind finite differences
MIT License
12 stars 2 forks source link

Correct mixed bc discretization derivation #141

Closed chiyahn closed 5 years ago

chiyahn commented 5 years ago

Resolves #140 -- WIP

codecov-io commented 5 years ago

Codecov Report

Merging #141 into master will increase coverage by 0.6%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #141     +/-   ##
=========================================
+ Coverage   98.61%   99.21%   +0.6%     
=========================================
  Files           5        5             
  Lines          72      127     +55     
=========================================
+ Hits           71      126     +55     
  Misses          1        1
Impacted Files Coverage Δ
src/types.jl 100% <0%> (ø) :arrow_up:
src/operators.jl 100% <0%> (ø) :arrow_up:
src/utilities/extrapolatetoboundary.jl 87.5% <0%> (+4.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a7b479...cf908b6. Read the comment docs.

chiyahn commented 5 years ago

Ready for review @ajozefiak @jlperla

chiyahn commented 5 years ago

There was one mistake in the formula. Made a fix at 5e927b9

chiyahn commented 5 years ago

@ajozefiak @jlperla Review should be done after #159 is complete -- merging this PR for now