I am concerned about two things here: (1) interior is the sort of function name that could end up clashing with all sorts of packages since Julia has weird namespace lookup rules and (2) that if we extend this to include multiple dimensions or thicker boundaries, we would need to have the boundary conditions to do the calculation. So,
[x] Change interior(x̄) to be interiornodes(x̄, bc) where the bc is ignored for the current dispatch (but we might use it later) (Resolved by 8c4910c)
chiyahn
commented
5 years ago
I am concerned about two things here: (1)
interioris the sort of function name that could end up clashing with all sorts of packages since Julia has weird namespace lookup rules and (2) that if we extend this to include multiple dimensions or thicker boundaries, we would need to have the boundary conditions to do the calculation. So,interior(x̄)to beinteriornodes(x̄, bc)where thebcis ignored for the current dispatch (but we might use it later) (Resolved by 8c4910c)