QuantEcon / book-dp1-public-companion

Dynamic Programming Volume 1
https://quantecon.github.io/book-dp1-public-companion/
BSD 3-Clause "New" or "Revised" License
109 stars 23 forks source link

Enable Github Actions for building #15

Closed mmcky closed 1 year ago

mmcky commented 1 year ago

@orectique can you please review this build

https://64fc037ed0af9f2eff6bc494--poetic-sprite-e126a3.netlify.app/jl/introductions

it has some missing packages like Distributions for jl?

netlify[bot] commented 1 year ago

Deploy Preview for poetic-sprite-e126a3 ready!

Name Link
Latest commit 569be5d1c5230dde0a7c887f83fb5a560ebe98f0
Latest deploy log https://app.netlify.com/sites/poetic-sprite-e126a3/deploys/650139507608900008511ecb
Deploy Preview https://deploy-preview-15--poetic-sprite-e126a3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mmcky commented 1 year ago

@orectique please feel free to push directly to this branch.

orectique commented 1 year ago

@orectique can you please review this build

https://64fc037ed0af9f2eff6bc494--poetic-sprite-e126a3.netlify.app/jl/introductions

it has some missing packages like Distributions for jl?

I am facing that on my local Linux version as well. Will figure it out.

I'll add LaTeX libraries to the environment.yml file as well.

mmcky commented 1 year ago

I'll add LaTeX libraries to the environment.yml file as well.

Best to uncomment the LaTeX installs in .github/workflows/ci.yml if you need LaTeX support on the build system

orectique commented 1 year ago

@orectique please feel free to push directly to this branch.

@mmcky I do not have permissions to push to this repo.

mmcky commented 1 year ago

@orectique thanks.

Are you still working on the following issue:

PyError ($(Expr(:escape, :(ccall(#= /home/runner/.julia/packages/PyCall/ilqDX/src/pyfncall.jl:43 =# @pysym(:PyObject_Call), PyPtr, (PyPtr, PyPtr, PyPtr), o, pyargsptr, kw))))) <class 'FileNotFoundError'>
mmcky commented 1 year ago

@orectique not sure what is going on with PyCall -- I have installed it, linked it to python but no luck in getting the PyCall fixed so far.

mmcky commented 1 year ago

@orectique I would recommend the following workflow:

Step 1: Build a Jupyter book Project from the source files Step 2: Run jupyter-book over the project to build html etc.

That would reduce the complexity in diagnosing this issue.

If you have time this afternoon to make this refactor that would be great. @jstac needs this site up and running by his morning (US time) so I have some time tomorrow morning to integrate into the textbook site.

orectique commented 1 year ago

PyCall has been giving me trouble as well.

I'll split the script into two right away.

mmcky commented 1 year ago

Nice work @orectique.

When you get time (not urgent) can you document what the main issues were around julia and pycall and I might add that as configuration into the quantecon manual to retain this knowledge.

mmcky commented 1 year ago

@orectique can you confirm with the two py files do we only need to run

python create_code_book.py

or do we need to add python create_jb.py?

Thanks for confirmation.

orectique commented 1 year ago

@mmcky I've split create_code_book.py into two parts - create_jb.py (which compiles the scripts into the JB format - to be run when the scripts are updated) and build_jb.py (which basically runs jb build).

create_jb.py does not build the book. Both scripts will have to be called in succession.

The current workflow uses create_code_book.py. We can swap it out for the two scripts if you'd prefer that.

mmcky commented 1 year ago

thanks @orectique no I just wanted to make sure I was building things correctly on GitHub actions. I think in the future we will revert to calling jupyter book directly on the code-book files but this works well for now.

mmcky commented 1 year ago

@orectique once this passes are you happy for me to merge?

orectique commented 1 year ago

@mmcky yep. I think we can go ahead and merge.