QuantEcon / jupinx

Jupyter + Sphinx Utilities and Tools
https://quantecon.github.io/jupinx/
20 stars 4 forks source link

BUG: Review Popen calls for running Servers #56

Closed mmcky closed 5 years ago

mmcky commented 5 years ago

It looks like jupinx is using 100% cpu while it waits for users to close the server using Ctrl-C.

https://files.slack.com/files-pri/T6A2RJC1F-FM69P2T2S/htop.png

We should review how Popen opens the servers and closes them at exit.

mmcky commented 5 years ago

@AakashGfude perhaps we should review how jupyter actually launch servers and implement something similar so we aren't just using Popen but rather a direct call to launch the server so that we have more control?

https://github.com/jupyter/notebook

mmcky commented 5 years ago

I think this file should give us some insight

https://github.com/jupyter/notebook/blob/master/notebook/notebookapp.py