search

QuantEcon / lecture-datascience.myst

Source repository for QuantEcon Datascience
https://datascience.quantecon.org
25 stars 21 forks source link

Use arguments, not variables in outer scope #245

Closed odanoburu closed 5 months ago

odanoburu commented 5 months ago

The function call following this definition passes X_test and y_test as arguments, so the error went unnoticed.

doctor-phil commented 5 months ago

Hey @odanoburu , thanks for running through these patches.

It'd be good to have these changes pushed to an internal branch first so we can make sure there is a preview build before merging to main (see #243). I created a new branch called patches that I'll keep up to date with main.

Just wanted to ask that any future PRs like this be directed to the patches branch so we can debug before merging to main, if necessary. I'll take care of this one, though.

Thanks again!

odanoburu commented 5 months ago

No problem, I thank you for the material! I've been a bit lazy in submitting patches through github instead of doing it locally, rebuilding, and pushing it to my fork; I noticed you've had to correct a small mistake I introduced in another PR, so I'll be more careful from now on.

doctor-phil commented 5 months ago

No worries! Really appreciate the patches.