search

QuantEcon / lecture-jax

Lectures on Quantitative Economics Using JAX
https://jax.quantecon.org/
28 stars 4 forks source link

MAINT: Use np.interp as supported by numba #138

Closed mmcky closed 7 months ago

mmcky commented 7 months ago

This PR switches from interpolation package to use np.interp as this is now supported directly by numba

https://numba.pydata.org/numba-doc/dev/developer/autogen_numpy_listing.html#numpy.interp

ref: https://github.com/QuantEcon/QuantEcon.py/issues/722 and https://github.com/QuantEcon/QuantEcon.py/pull/724

netlify[bot] commented 7 months ago

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
Latest commit 73cf999ebe9cf982c3f658e2ae57bb01a21baad2
Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/65e537ba1774da0008457d92
Deploy Preview https://deploy-preview-138--incomparable-parfait-2417f8.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 7 months ago

🚀 Deployed on https://65e53ae5b5d5f10cb0b80a69--incomparable-parfait-2417f8.netlify.app

mmcky commented 7 months ago

@kp992 thanks for review. If you could let me know you approve in the future that would be great (rather than merge).

I will do some benchmarks to see if np.interp or our jit version is faster.

kp992 commented 7 months ago

Okay, noted. Thanks @mmcky