QuantEcon / lecture-jax

Lectures on Quantitative Economics Using JAX
https://jax.quantecon.org/
28 stars 4 forks source link

Split optimal savings #151

Closed jstac closed 6 months ago

jstac commented 6 months ago

Split optimal savings lecture in two, add vmap version, numpy comparison.

netlify[bot] commented 6 months ago

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
Latest commit fbec3a7bbbb3d3bbd6e6ab1d5cd68a0b92c7c4fa
Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/65f2431d3df8320008538742
Deploy Preview https://deploy-preview-151--incomparable-parfait-2417f8.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jstac commented 6 months ago

@mmcky Would you mind to see if you can tidy this up?

Once it's fixed and merged, could you please refresh the live site.

mmcky commented 6 months ago

@jstac when you say tidy-up do you mean proof-read and look out for any style regressions?

github-actions[bot] commented 6 months ago

🚀 Deployed on https://65f24bb17ef5a953dc41fb07--incomparable-parfait-2417f8.netlify.app

jstac commented 6 months ago

@jstac when you say tidy-up do you mean proof-read and look out for any style regressions?

Just fix the build error -- which I see you've done -- and it also looks like there's a merge conflict in _toc.

If you look at the toc file in this PR you can see what I'm trying to achieve.

Thanks!

mmcky commented 6 months ago

@jstac 07bb3d3 just makes minor modifications in linking and adding figure numbers, removing fontsize and specific figures sizes etc.

mmcky commented 6 months ago

@jstac this is building and looking good 👍

mmcky commented 6 months ago

Once it's fixed and merged, could you please refresh the live site.

I will merge this now and update the live site.

jstac commented 6 months ago

Thanks @mmcky , please let me know when the new version is live.

mmcky commented 6 months ago

I'll trigger a build as soon as the cache has finished building 👍

mmcky commented 6 months ago

@jstac new version is now live.