Closed jstac closed 3 weeks ago
I did a thorough search: all Jax lectures except for mle have the issues of either not using block_until_ready
or running twice to eliminate compilation time. (So I will not list them here)
Edit: given so many lectures, I list them here for tracking the modification progress:
I spotted two extra issues during the searching:
tic/toc
and Python time magic interchangeably in different lectures,Regarding issue 1, I suggest we use our timing methods, tic/toc
, for all Jax lectures.
Regarding issue 2, I suggest we also run the Numba code twice to eliminate the compilation.
Thanks @shlff , these are good suggestions.
I suggest we use our timing methods, tic/toc, for all Jax lectures.
Actually I suggest that we use %time and %%time when possible --- unless we are recording the time to compare it to something later. If we are recording the time, let's use time.time()
, since it's conventional in Python.
Thanks for your comments @jstac . That's a better idea!
In this lecture, when we do the timings, we do not use
block_until_ready
and we don't run twice to eliminate compile time.https://jax.quantecon.org/opt_savings_1.html
I think this is probably true in a few other lectures.
We need a review of all timings, to make sure that we run twice, noting the time on both occasions, and that we block until ready.
Required actions:
block_until_ready
block_until_ready
as required