QuantEcon / lecture-python-advanced.myst

Advanced Quantitative Economics with Python
https://python-advanced.quantecon.org
26 stars 21 forks source link

Remove unused imports #142

Closed Smit-create closed 10 months ago

Smit-create commented 1 year ago

Fixes #139

This PR:

  1. removes unused imports
  2. removes extra white space
jstac commented 1 year ago

Many thanks @Smit-create . I will leave this one for @mmcky , who is on holidays but will be back soon.

mmcky commented 1 year ago

@Smit-create is this still relevant. Let me know and I can review + merge. Thanks.

mmcky commented 11 months ago

@Smit-create do you know what this RED text means in a GitHub diff? I haven't seen this before

Screenshot 2023-12-19 at 5 18 28 pm
Smit-create commented 11 months ago

Thanks @mmcky. Sorry for the delayed response. This color is rarely seen but I read somewhere that it denotes a syntax error. I am not sure how that is coming up in a .md file.

Smit-create commented 11 months ago

This is the fix: https://github.com/QuantEcon/lecture-python-advanced.myst/pull/142/commits/d42007d3eeaf448f4f3077e3e7df46891e2c0f7c that removes the dark red background. GitHub probably thought it was a syntax error in md format.

mmcky commented 11 months ago

thanks @Smit-create

mmcky commented 11 months ago

@Smit-create I am seeing two execution failures on the preview build that is not on the current live site

https://6581b2a87b7a6f228f93f7a7--wonderful-lalande-528d1c.netlify.app/status

NameError: name 'float64' is not defined
NameError: name 'njit' is not defined
Smit-create commented 11 months ago

I see those are the missing cases as the snippet is loaded from _static. I'll try to fix them.

Just wanted to check that why the CI didn't fail on this?

mmcky commented 11 months ago

I see those are the missing cases as the snippet is loaded from _static. I'll try to fix them.

Just wanted to check that why the CI didn't fail on this?

The -n -W --keep-going is missing from ci.yml is why. 🤔

mmcky commented 10 months ago

@Smit-create any luck on fixing the final two issues?

Smit-create commented 10 months ago

Sure, fixing them.