search

QuantEcon / lecture-python-advanced

Source files for https://python-advanced.quantecon.org
BSD 3-Clause "New" or "Revised" License
41 stars 22 forks source link

modify `opt_tax_recur` #204

Closed shizejin closed 3 years ago

shizejin commented 3 years ago

Refactorize code in the lecture opt_tax_recur as listed in #203.

github-actions[bot] commented 3 years ago

🚀 Deployed on https://60c09e8744acd5c5343bfc9e--cocky-austin-ce446a.netlify.app

mmcky commented 3 years ago

@shizejin can you ping me when this is ready to review (from a publishing perspective). Thanks!

shizejin commented 3 years ago

@shizejin can you ping me when this is ready to review (from a publishing perspective). Thanks!

Sure @mmcky , I will let you know!

shizejin commented 3 years ago

Hi @mmcky, with the careful review and help from @QBatista, I think this PR is now ready for your review from a publishing perspective.

mmcky commented 3 years ago

thanks @shizejin and @QBatista -- amazing work! Does @thomassargent30 need to review this or has this happened already?

shizejin commented 3 years ago

Hi @mmcky, thanks so much for merging! I think Tom approves this. And @QBatista would you like to continue working under the mod_amss branch? In that case we should probably restore the branch.

mmcky commented 3 years ago

@QBatista It is usually better to get the latest master and then work from that in a new branch. I have found that workflow typically saves a lot of headaches when time comes to merge.