QuantEcon / lecture-python-intro

An Undergraduate Lecture Series for the Foundations of Computational Economics
https://intro.quantecon.org/
39 stars 20 forks source link

[scalar_dynamic] Update editorial suggestions #430

Closed longye-tian closed 5 months ago

longye-tian commented 5 months ago

Dear John @jstac,

This pull request updates the editorial suggestion in #426. The details are shown as follows.

(Delete %matplotlib inline)

Best ❤️ Longye

netlify[bot] commented 5 months ago

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
Latest commit 516c2af5a08aca72091731f7f7501b7be0235dd3
Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/662e0209d937740008116653
Deploy Preview https://deploy-preview-430--taupe-gaufre-c4e660.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jstac commented 5 months ago

Thanks @longye-tian, much appreciated! This all looks good to me.

@mmcky , could you please guide this through the merge process and close any relevant issues?

mmcky commented 5 months ago

thanks @longye-tian this code cell is not executing in scalar-dynam

------------------
xmin, xmax = 0, 4  # Suitable plotting region.

plot45(g, xmin, xmax, 0, num_arrows=0)
------------------

due to a key error

KeyError't+1'
github-actions[bot] commented 5 months ago

🚀 Deployed on https://662e03e36a97628f2fb37ed8--taupe-gaufre-c4e660.netlify.app

mmcky commented 5 months ago

@longye-tian do you have any time to work on these comments?

https://github.com/QuantEcon/lecture-python-intro/issues/426#issue-2251735020

longye-tian commented 5 months ago

@longye-tian do you have any time to work on these comments?

#426 (comment)

Hi @mmcky , I can work on these comments as well :))

I think the other comments in #426 require a separate pull request. I will create a new pull request for other comments.

Best, Longye

mmcky commented 5 months ago

thanks @longye-tian -- @jstac this PR is ready for review.

jstac commented 5 months ago

Many thanks @longye-tian , much appreciated. Merging.