QuantEcon / lecture-python-intro

An Undergraduate Lecture Series for the Foundations of Computational Economics
https://intro.quantecon.org/
34 stars 17 forks source link

[lp_intro] update suggestions #474

Open longye-tian opened 5 days ago

longye-tian commented 5 days ago

Dear John @jstac,

I have updated some of the lp_intro.md lecture according to #469 (mainly involving typos, and styles)

In particular, the changes include:

Code

One thing I find is that the column header is automatically in bold, so I cannot fix it by changing the MD file. For the suggestions related to materials, I will create a separate issue tracker and pull request.

Best ❀️ Longye

netlify[bot] commented 5 days ago

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
Latest commit 18952a99b13e9182eae10d39df10e442b7cb9c4f
Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/667bbe52d7a5e20008144763
Deploy Preview https://deploy-preview-474--taupe-gaufre-c4e660.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 5 days ago

πŸš€ Deployed on https://667bc05b498501857c245c0b--taupe-gaufre-c4e660.netlify.app

jstac commented 4 days ago

Many thanks @longye-tian , this is much appreciated.

@mmcky , can you please review?

mmcky commented 4 days ago

thanks @longye-tian

One thing I find is that the column header is automatically in bold

Is this in some code output? Or a part of the document?

longye-tian commented 4 days ago

thanks @longye-tian

One thing I find is that the column header is automatically in bold

Is this in some code output? Or a part of the document?

Hi Matt @mmcky ,

It is part of the markdown table, for example in the lp_intro.md, we have the following table,

Product 1 Product 2
Material 2 5
Labor 4 2
Revenue 3 4

The default setting in the md table is that the column header is in bold. I wish to unbold the column header as according to our style guide, the bold font is for definition. Do you know how to do that? Thank you Matt!

Best, Longye

mmcky commented 3 days ago

thanks @longye-tian

One thing I find is that the column header is automatically in bold

Is this in some code output? Or a part of the document?

Hi Matt @mmcky ,

It is part of the markdown table, for example in the lp_intro.md, we have the following table,

Product 1 Product 2 Material 2 5 Labor 4 2 Revenue 3 4 The default setting in the md table is that the column header is in bold. I wish to unbold the column header as according to our style guide, the bold font is for definition. Do you know how to do that? Thank you Matt!

Best, Longye

Thanks for explaining this @longye-tian. If this is part of the table rendering then that would be controlled by the theme.

@jstac would you like all table headers to be not bolded? It is common for them to be bolded but if that interferes with usage from our style guide then we should be able to update the style.

jstac commented 3 days ago

@mmcky @longye-tian Let's go with the default theme for marking up tables. It's best to stick with defaults when possible.

Thanks again @longye-tian and thanks @mmcky for the review. Merging.