QuantEcon / lecture-python-intro

An Undergraduate Lecture Series for the Foundations of Computational Economics
https://intro.quantecon.org/
34 stars 18 forks source link

[unpleasant] Address Comments on Styles and Improve Citation Style #495

Closed HumphreyYang closed 1 day ago

HumphreyYang commented 4 days ago

This PR resolves #445.

netlify[bot] commented 4 days ago

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
Latest commit 27e56483a5e7f77557f0afab2bf0f2f90fd2cbed
Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66860c736177dd00083bceac
Deploy Preview https://deploy-preview-495--taupe-gaufre-c4e660.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 days ago

🚀 Deployed on https://66860e4269854550340179d2--taupe-gaufre-c4e660.netlify.app

HumphreyYang commented 4 days ago

Many thanks @mmcky.

The old version is

Screenshot 7

and the cite:t version is

Screenshot 6

I think cite:t is closer to the citation style we want to use here, but please let me know if I should revert this change.

mmcky commented 2 days ago

thanks @HumphreyYang this is super interesting.

@jstac if we want to migrate to cite:t we will need to do a bulk edit across all lectures. Currently we have author_year style set for bibtex and the differences are shown above.

The engineer in me has always liked the reference in brackets [ but cite:t is closer to the usual text representation in economics.

jstac commented 2 days ago

@mmcky @HumphreyYang Regarding cites, that's a tough one. There are cites in other lectures that don't suit this style (should we make a blanket change). See, e.g., https://jax.quantecon.org/aiyagari_jax.html

I'd like to stay out of this if I can :grimacing:

mmcky commented 2 days ago

@HumphreyYang I think my preference would be to use the global author_year style that uses brackets as it is globally enabled. That will improve consistency.

HumphreyYang commented 1 day ago

Hi @mmcky, I have addressed your and @jstac's comments. Please let me know if there is anything else I can further improve.

jstac commented 1 day ago

Many thanks @HumphreyYang .