QuantEcon / lecture-python-intro

An Undergraduate Lecture Series for the Foundations of Computational Economics
https://intro.quantecon.org/
41 stars 21 forks source link

[solow] Update unfinished suggestions #511

Closed SylviaZhaooo closed 4 months ago

SylviaZhaooo commented 4 months ago

Dear John @jstac,

I have addressed almost all the suggestions in issue #427. However, I would appreciate your help with the last one, which involves changing the order of two lectures.

Best regards, Sylvia

netlify[bot] commented 4 months ago

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
Latest commit d783d83f891234d313d9005b429f75f8b8ce4bec
Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66a0a72a7bfc2c0008531e1d
Deploy Preview https://deploy-preview-511--taupe-gaufre-c4e660.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 months ago

🚀 Deployed on https://66a0a8f4c0cd8ec8d284f9a5--taupe-gaufre-c4e660.netlify.app

jstac commented 4 months ago

Thanks @SylviaZhaooo .

In the lectures we do not combine sentences --- see https://manual.quantecon.org/styleguide/writing.html#general-writing-advice. In particular, we never have a full stop and then continue on the same line.

How about adding this information after the bullet points?

However, I would appreciate your help with the last one, which involves changing the order of two lectures.

Please move that to a separate issue, so we can close #427

SylviaZhaooo commented 4 months ago

Thanks @SylviaZhaooo .

In the lectures we do not combine sentences --- see https://manual.quantecon.org/styleguide/writing.html#general-writing-advice. In particular, we never have a full stop and then continue on the same line.

How about adding this information after the bullet points?

However, I would appreciate your help with the last one, which involves changing the order of two lectures.

Please move that to a separate issue, so we can close #427

Thanks @jstac.

The purpose of saying, "However, I would appreciate your help with the last one, which involves changing the order of two lectures" refers to the last suggestion I want you to check in the last suggestion in issue #427. I think it is a misunderstanding due to my expression, sorry about that. And for the writing style thing, I will be going through the webpage you mentioned. If nothing else is wrong, this pr can be closed.

mmcky commented 4 months ago

@SylviaZhaooo I can change the order of the two lectures in a separate PR. Let's not incorporate that here.

SylviaZhaooo commented 4 months ago

Thanks @mmcky, I will check it.

SylviaZhaooo commented 4 months ago

@SylviaZhaooo I can change the order of the two lectures in a separate PR. Let's not incorporate that here.

I see, thanks @mmcky.