QuantEcon / lecture-python-intro

An Undergraduate Lecture Series for the Foundations of Computational Economics
https://intro.quantecon.org/
41 stars 21 forks source link

[prob_dist] Update suggestions #519

Closed longye-tian closed 4 months ago

longye-tian commented 4 months ago

Dear John @jstac ,

This pull request update prob_dist.md according to #402 .

In particular, this pull request

Best ❤️ Longye

netlify[bot] commented 4 months ago

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
Latest commit 65749428849211959a68e4d0b03ecf343b18fde3
Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/669f0664a6e0c900080f0a90
Deploy Preview https://deploy-preview-519--taupe-gaufre-c4e660.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 months ago

🚀 Deployed on https://669f08437858e384550fb936--taupe-gaufre-c4e660.netlify.app

longye-tian commented 4 months ago

thanks @longye-tian.

I think we should use lower case for the text titles on the x and y axis. CDF and PDF are acronyms so I think they should remain capitalised but I will confirm with @jstac

https://manual.quantecon.org/styleguide/figures.html

Hi Matt,

Thanks! Just updated the labels to lowercase letters except the PMF, CDF, PDF and KDE.

Best, Longye

mmcky commented 4 months ago

thanks @longye-tian.

@jstac this is ready for your final review. It is my understanding that acronyms like PDF should be capitalized. Is that correct?

mmcky commented 4 months ago

thanks @longye-tian for these updates. I will merge this now.