[TEST]: Testing jupyter-book==0.15.1 (upcoming release)

[AakashGfude]

Testing with Jupyter-book PR: https://github.com/executablebooks/jupyter-book/pull/1842

[github-actions[bot]]

🚀 Deployed on https://63649f1db8dfd54756486b0b--epic-agnesi-957267.netlify.app

[mmcky]

@AakashGfude this looks pretty good to me. Some new styles I see for dropdowns coming through.

[AakashGfude]

Hi @mmcky it looks good to me as well. Although the 'View Source' link seems to be broken (which is probably not related to this PR). I will create an issue for that.

[mmcky]

Hi @mmcky it looks good to me as well. Although the 'View Source' link seems to be broken (which is probably not related to this PR). I will create an issue for that.

Is this an issue on the current live site as well?

[github-actions[bot]]

🚀 Deployed on https://641a352f899e0605be0eac28--epic-agnesi-957267.netlify.app

[mmcky]

• [x] check with quantecon-book-theme

[mmcky]

@HumphreyYang @shlff

This is a build of the python-programming site using the latest and greatest jupyter-book==0.15. This is building with a new major version of sphinx so it would be really helpful if you could take a quick look around at the deployment preview and let me know if you spot any issues.

https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/intro.html

It looks pretty good to me.

The things that aren't working for this build:

1. pdf builds
2. download notebook builds

[shlff]

Thanks @mmcky and @AakashGfude . There are two issues I've spotted so far.

The first is that there are some enormous space gaps between lines, like this:

This issue occurs in the following lectures:

• https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/python_oop.html
• https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/scipy.html
• https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/parallelization.html
• https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/writing_good_code.html

Another issue is that there are texts overlapped in the outputs in the lecture pandas:

• https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/pandas.html

like this:

[mmcky]

thanks @shlff this is really helpful.

[mmcky]

@AakashGfude the pandas output is concerning. Do you think this is a theme issue or it has changed due to the way myst-nb parses executable output?

[HumphreyYang]

Thanks @mmcky and @AakashGfude . There are two issues I've spotted so far.

The first is that there are some enormous space gaps between lines, like this:

I also noticed this, and I found it relates to the in-text math symbols we use. Also see here: https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/getting_started.html#inserting-unicode-e-g-greek-letters

[HumphreyYang]

Thanks @mmcky and @AakashGfude . There are two issues I've spotted so far. The first is that there are some enormous space gaps between lines, like this:

I also noticed this, and I found it relates to the in-text math symbols we use. Also see here: https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/getting_started.html#inserting-unicode-e-g-greek-letters

Many thanks @AakashGfude @mmcky @shlff. I am not sure if it is intended, but the graphs generated by code now are larger than the past versions, and the shape is varying instead of having the same aspect ratio as they used to be. See another example here: versions now compared to older versions.

[mmcky]

I also noticed this, and I found it relates to the in-text math symbols we use. Also see here: https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/getting_started.html#inserting-unicode-e-g-greek-letters

@HumphreyYang are you saying the the additional spaces are only when we use greek unicode letters?

[mmcky]

@shlff

it looks like

https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/python_oop.html

is resolved in sphinx-book-theme

https://63cf4ba2a0f50b6ae322413f--epic-agnesi-957267.netlify.app/python_oop.html#special-methods

@AakashGfude it looks like there must be some style inheritance issues in quantecon-book-theme

[mmcky]

@shlff the pandas issue also looks resolved when using sphinx-book-theme

https://63cf4ba2a0f50b6ae322413f--epic-agnesi-957267.netlify.app/pandas.html#dataframes

[mmcky]

I am not sure if it is intended, but the graphs generated by code now are larger than the past versions, and the shape is varying instead of having the same aspect ratio as they used to be. See another example here: versions now compared to older versions.

Thanks @HumphreyYang I agree -- this has also changed in sphinx-book-theme it seems so there must be a change with regards to fig size imports. I will check with the Jupyter Book team.

Edit: @HumphreyYang it actually looks like many figures are a bit smaller now than in the current live site. Is that what you are seeing?

[HumphreyYang]

I am not sure if it is intended, but the graphs generated by code now are larger than the past versions, and the shape is varying instead of having the same aspect ratio as they used to be. See another example here: versions now compared to older versions.

Edit: @HumphreyYang it actually looks like many figures are a bit smaller now than in the current live site. Is that what you are seeing?

I think they are larger actually: Edit: @mmcky The link I attached is a very old preview dating back to when I contributed to the matplotlib lecture last year.

Old:

New:

They are screenshots within the same window.

[HumphreyYang]

I also noticed this, and I found it relates to the in-text math symbols we use. Also see here: https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/getting_started.html#inserting-unicode-e-g-greek-letters

@HumphreyYang are you saying the the additional spaces are only when we use greek unicode letters?

I am not sure if it is related to $ or unicode letters but it appears to me that the gaps appear when we use $$ in text.

[mmcky]

@HumphreyYang and @shlff thanks for your reviews. It looks like we will need to make changes to the quantecon-book-theme before we deploy the latest jupyterbook but all of the pickups seem to be resolved when using sphinx-book-theme

cc: @AakashGfude

[AakashGfude]

@HumphreyYang @shlff @mmcky, the table seems to be working fine here: https://63ce12b93d29576b04813b49--epic-agnesi-957267.netlify.app/pandas.html , apart from a minor overlap in the entries.

which is taken care of in sphinx-book-theme, so probably would just inherit its style.

[AakashGfude]

fixed in this commit https://github.com/QuantEcon/quantecon-book-theme/pull/186/commits/be517c53fae3d81575755279c0739d43cd3dbb3e, the table issue.

[mmcky]

thanks @shlff @HumphreyYang @AakashGfude for your input into this testing campaign. This is now building on the latest jupyterbook and quantecon-book-theme and looking pretty good.

• [x] table rendering is fixed https://641799b601f1ec2effb07975--epic-agnesi-957267.netlify.app/pandas.html

some of the images might still be a bit larger but we can iterate through the lectures at some point and review them.

[mmcky]

Closed by #267