QuantEcon / lecture-python-programming.myst

Python Programming for Finance and Economics
https://python-programming.quantecon.org
43 stars 26 forks source link

[python_by_example] Remove the unnecessary text for matplotlib inline #272

Closed HengchengZhang closed 1 year ago

HengchengZhang commented 1 year ago

Hi @jstac and @mmcky, this PR fix #271.

I've tested it in my local environment and it looks well after deleting the text.

github-actions[bot] commented 1 year ago

🚀 Deployed on https://6434e0151670f16c6033a3e8--epic-agnesi-957267.netlify.app

jstac commented 1 year ago

Nice work @HengchengZhang , many thanks.

Please fix the failing build or ping @mmcky if you're not sure what's happening.

mmcky commented 1 year ago

@HengchengZhang would you mind to review the links that are reported as broken such as

(        about_py: line   85) broken    https://www.sciencedirect.com/science/article/pii/S1477388021000177 - 403 Client Error: Forbidden for url: https://www.sciencedirect.com/science/article/pii/S1477388021000177

there are a couple of additional ones in the GitHub actions output for the Link Checker

https://github.com/QuantEcon/lecture-python-programming.myst/actions/runs/4663763516/jobs/8255387311?pr=272

HengchengZhang commented 1 year ago

Thanks @jstac and @mmcky, I checked these this afternoon but I think the broken links it gives all work actually.

mmcky commented 1 year ago

Roger that - the false positives are annoying with the link checker. We may need to think about seeing if there are some checks we can skip to reduce the false positivity rate at some point.