Closed orectique closed 9 months ago
🚀 Deployed on https://6577d25656128f7bc9b6e0cd--epic-agnesi-957267.netlify.app
Thanks @orectique . Could you please look into the failing link check?
I've verified that the links flagged by the link checker are all functional.
It might be that the flagged sites are shutting down automated access.
@mmcky or @HumphreyYang , could you please advise? I think we just ignore the link checker in this case?
Hi @jstac, @mmcky and @HumphreyYang, I checked these links manually and they all should be false positives. My opinion is to add them to the ignore list.
Hi @jstac, @mmcky and @HumphreyYang, I checked these links manually and they all should be false positives. My opinion is to add them to the ignore list.
Many thanks @HengchengZhang and @jstac. I also think we can have it on since it still works on other links. We can manually check the white list when we have major releases as long as the list is not too long. We can consider disabling it in the future if the list of false positives is getting too long.
Thanks @HengchengZhang and @HumphreyYang . Let's ignore as suggested.
@orectique Nice work on this lecture. Let's meet up and discuss it. I'll contact you to set up a time.
Hi @jstac I added them to the ignore list and it's working now.
Thanks, @jstac.
thanks @orectique -- this looks like it is in-work but let me know if you need a review etc.
@mmcky This needs a review, please. I've added new content to the Getting started lecture and revised the workspaces lecture.
Sorry @orectique this slipped through my radar. Can you update on the latest main and then ping me for review. Thanks,.
Hi @mmcky,
Thanks for the review. I have merged changes on Main to this branch. There should be no conflicts.
thanks @orectique I reviewed 95de21e and see they resolved all the outstanding items. Thank you.
thanks @orectique -- @jstac this is now at review stage.
Thanks @mmcky , looks good to me. It's nicely written.
thanks @jstac and @orectique for these improvements.
fixes #279