search

QuantEcon / lecture-python-programming.myst

Python Programming for Finance and Economics
https://python-programming.quantecon.org
43 stars 26 forks source link

MAINT: Upgrade software stack #292

Closed mmcky closed 11 months ago

mmcky commented 11 months ago

This PR upgrades to:

mmcky commented 11 months ago

@HumphreyYang would you have time to look into this link checker result?

github-actions[bot] commented 11 months ago

🚀 Deployed on https://6526169a258702793a51079e--epic-agnesi-957267.netlify.app

mmcky commented 11 months ago
HumphreyYang commented 11 months ago

Many thanks @mmcky,

The link checker is all green now.

mmcky commented 11 months ago

thanks @HumphreyYang love your work.

mmcky commented 11 months ago
mmcky commented 11 months ago

@HumphreyYang @HengchengZhang if you had 10minutes would you mind to look through the latest deployment and let me know if you spot any issues or regressions.

HengchengZhang commented 11 months ago

Hi Matt, the new search bar and the dark mode looks all good to me.

One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?

It is still great if we use the current theme.

mmcky commented 11 months ago

Hi Matt, the new search bar and the dark mode looks all good to me.

One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?

It is still great if we use the current theme.

Thanks @HengchengZhang -- I agree we need to make improvements to the theme. Are you indicating that quantecon-book-theme==0.6.0 is worse than our current live site which uses quantecon-book-theme==0.5.3?

HengchengZhang commented 11 months ago

Hi Matt, the new search bar and the dark mode looks all good to me. One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible? It is still great if we use the current theme.

Thanks @HengchengZhang -- I agree we need to make improvements to the theme. Are you indicating that quantecon-book-theme==0.6.0 is worse than our current live site which uses quantecon-book-theme==0.5.3?

Hi @mmcky I think the new quantecon-book-theme==0.6.0 is better than current site but the code part can be improved. But still the new theme is pretty nice.

mmcky commented 11 months ago

thanks @HumphreyYang and @HengchengZhang for your review and comments.

Upgrading to the latest versions now.