QuantEcon / lecture-python-programming.myst

Python Programming for Finance and Economics
https://python-programming.quantecon.org
43 stars 26 forks source link

ENH: Update to quantecon-book-theme==0.6.1 #295

Closed mmcky closed 10 months ago

mmcky commented 11 months ago

This PR updates to 0.6.1

https://github.com/QuantEcon/quantecon-book-theme/releases/tag/v0.6.1

github-actions[bot] commented 11 months ago

🚀 Deployed on https://652f4bf92260c342bff1ebae--epic-agnesi-957267.netlify.app

mmcky commented 11 months ago

@AakashGfude thanks for this.

Is there a way to use an inverted quantecon logo for dark theme?

Also is there a lighter colour we can use for the right hand table of contents

Screenshot 2023-10-18 at 2 15 31 pm

also the title

Screenshot 2023-10-18 at 2 15 48 pm

Looking like a big improvement thought. Thanks.

cc: @HumphreyYang @HengchengZhang

AakashGfude commented 11 months ago

Thanks @mmcky . Yes, I will add a lighter color. Since that image is jpg, so, if I invert the colour, the logo colour changes as well, for example:

Screen Shot 2023-10-18 at 2 33 22 pm

We can either try to create a new image for dark mode, or use this?

Thanks for the right hand toc, will add the same styling as left-hand toc:

Screen Shot 2023-10-18 at 2 32 56 pm
mmcky commented 11 months ago

@DrDrij has a QuantEcon logo for dark backgrounds. I will try and dig it up. But it would be great if we can use a different logo to support dark mode.

mmcky commented 10 months ago

@AakashGfude here is one for black backgrounds

qe-logo-on-black

AakashGfude commented 10 months ago

Thanks @mmcky . I will get it done next week. When I am back to Canberra

mmcky commented 10 months ago

closing as we will upgrade to 0.6.2 instead with improved dark theme support