QuantEcon / lecture-python

Source files for https://python.quantecon.org
BSD 3-Clause "New" or "Revised" License
61 stars 21 forks source link

[15_samuelson]_modify_lists #299

Closed shlff closed 3 years ago

shlff commented 3 years ago

Good morning @jstac , this PR puts the following outside the lists following Samuelson used a *second-order linear difference equation* to represent a model of national output based on three components: in section Samuelson's Model of lecture samuelson:

I made this change because the other 3 points in the list are 3 components of the national output model mentioned above, but this point/sentence does not. It sounds like a remark on these 3 model components, so I treat it as a separate sentence outside the list.

github-actions[bot] commented 3 years ago

🚀 Deployed on https://5febc3fe8359042dc45100dd--practical-lalande-b89631.netlify.app

jstac commented 3 years ago

Thanks @shlff , I appreciate this suggestion.

However, as a stand-alone sentence, it is not grammatically correct. Could you please delete the words "The idea that"?

shlff commented 3 years ago

Thank for your great comments, @jstac . As you suggested, I correct the sentence as:

jstac commented 3 years ago

Thanks @shlff . Would you mind to check why the test is failing and see if you can fix it?

shlff commented 3 years ago

Dear @jstac , thanks for your kind instruction. Now the problem has been solved and the PR is ready for merging now.

The test was failing because the feature master branch of this PR was behind our current master branch.

(This occurs when we have many PRs to merge.)

This can be solved by rebasing the feature branch off of the latest version of master, please find here.

(The same solution applies to this one.)

jstac commented 3 years ago

Thanks @shlff , nice work.