search

QuantEcon / lecture-python

Source files for https://python.quantecon.org
BSD 3-Clause "New" or "Revised" License
61 stars 21 forks source link

[CI] Update Anaconda=2020.11 #329

Closed mmcky closed 3 years ago

mmcky commented 3 years ago

This PR updates the anaconda==2020.11 pin.

There are currently some issues with the publishing side of things when using the template files:

Note: all tests run so the actual lectures run fine in the latest anaconda -- this just impacts publishing and building.

mmcky commented 3 years ago

@AakashGfude this PR appears to be passing but it actually isn't if you take a look at the build logs for pdf

AakashGfude commented 3 years ago

@AakashGfude this PR appears to be passing but it actually isn't if you take a look at the build logs for pdf

So, this article.tplx issue came when updating conda? It was not there in the previous version?

mmcky commented 3 years ago

@AakashGfude this PR appears to be passing but it actually isn't if you take a look at the build logs for pdf

So, this article.tplx issue came when updating conda? It was not there in the previous version?

That is correct. I repined anaconda in https://github.com/QuantEcon/lecture-python/pull/327 so you can look at the build log there (or setup the conda environment locally).

I spent some time on it yesterday afternoon -- and make website seems to have an issue with the latest jinja2, and make pdf seems to have the tplx issue with nbconvert. There is an open issue on nbconvert about it as well https://github.com/jupyter/nbconvert/issues/1483 so maybe we can help them out.

mmcky commented 3 years ago

This is currently on hold and anaconda=2020.07 is used to build the website due to big changes introduce in nbconvert>=6

mmcky commented 3 years ago

Note: https://github.com/QuantEcon/lecture-python.myst/pull/42 is running on anaconda=2020.11 so may be worth waiting until we migrate.