[44_perm_income_cons]_typo

QuantEcon / lecture-python

Source files for https://python.quantecon.org

BSD 3-Clause "New" or "Revised" License

61 stars 21 forks source link

[44_perm_income_cons]_typo #338

Closed shlff closed 3 years ago

shlff commented 3 years ago

Hi @jstac , this PR corrects a possible typo in lecture perm_income_cons:

So the risk-free loans are being made from one person to another within our closed set of agent. -->> So the risk-free loans are being made from one person to another within our closed set of agents.

shlff commented 3 years ago

Hi @mmcky (cc: @AakashGfude ), I find there are some unsuccessful checks for this and another PR I submitted after this.

I checked it out that it is not due to merging conflicts like what I faced last time.

Would you mind having a look at them and helping me solve this issue when you have time? Many thanks!

(I will hold on submitting PRs now.)

github-actions[bot] commented 3 years ago

🚀 Deployed on https://5ff39d54fa93f935e75bff54--practical-lalande-b89631.netlify.app

mmcky commented 3 years ago

hey @shlff -- this looks like it is passing CI. It might be because your PR needs to be generated from the latest master so a rebase or merge in the latest master may fix your issue. Please feel free to ping me on Slack or we can Zoom.

shlff commented 3 years ago

hey @shlff -- this looks like it is passing CI. It might be because your PR needs to be generated from the latest master so a rebase or merge in the latest master may fix your issue. Please feel free to ping me on Slack or we can Zoom.

Great thanks for helping me fix this, @mmcky .

I updated and rebased the master in this and the other PR. Now, all these checks are successful! Great thx again!

jstac commented 3 years ago

Thanks @shlff and @mmcky