search

QuantEcon / lecture-python

Source files for https://python.quantecon.org
BSD 3-Clause "New" or "Revised" License
61 stars 21 forks source link

updated iterataion variable #384

Closed emilsavalan closed 2 years ago

emilsavalan commented 2 years ago

It calculates reservation wage correct anyway but because of using the same variable for iteration in a "while" and "for" loop, "max_iter" becomes useless, such that if choosing "max_iter" less than converging iteration number, it again continues to converge at this number of iterations which is higher than "max_iter". Also in a while loop, an iteration variable prints number of wage points, not consecutive numbers of iteration

jstac commented 2 years ago

Thanks @emilsavalan , much appreciated!

There is a similar problem in the function plot_value_function_seq just above. I'll fix that one.

jstac commented 2 years ago

@mmcky , should this PR generate a view on the compiled page?

mmcky commented 2 years ago

hey @jstac this is the old repo for python.quantecon.org

Changes should be made here:

https://github.com/quantecon/lecture-python.myst

One of the reasons I want to clean the RST based repos up and archive them.

jstac commented 2 years ago

Thanks @mmcky . I think it would be a good idea to archive them.

@emilsavalan , sorry about the hassle. Would you like to put in a fresh PR in the new repo, which @mmcky listed above? Or, if you prefer, I can make that change?

emilsavalan commented 2 years ago

@jstac , it is okay. I commited changes, please check it.

jstac commented 2 years ago

Thanks @emilsavalan .

I'll close this PR @mmcky and leave you to archive. Thanks in advance.