search

QuantEcon / lecture-source-py

Source files for "Lectures in Quantitative Economics" -- Python version
BSD 3-Clause "New" or "Revised" License
191 stars 77 forks source link

pandas_issue6 #890

Closed Harveyt47 closed 4 years ago

Harveyt47 commented 4 years ago

Hi @jstac , update ticker_data to 2019 data.

jstac commented 4 years ago

Thanks @Harveyt47.

The text mentions that it's 2013 data. Did you change that as well in another PR?

Harveyt47 commented 4 years ago

Thanks @jstac , I didn't, I'll add that edit to this PR.

shlff commented 4 years ago

Hi @jstac , as I showed to you yesterday afternoon, given your comments, I fixed #889 by 3 points:

  1. Read 2019 data live,
  2. Change the year from 2013 to 2019,
  3. Modify the solution code by using np.diff().

You can see this updated exercise and its solution in Jupyter-notebook version from my notes.. Would you mind confirming these changes?

Harveyt47 commented 4 years ago

Thanks @shlff , looks good to me.

sayaikegawa commented 4 years ago

thanks @shlff , looks good.

sayaikegawa commented 4 years ago

Thanks @Harveyt47 , that looks good for me.

shlff commented 4 years ago

Thanks, @Harveyt47 and @sayaikegawa . Good evening, @jstac , I did 3 things to rescue this PR:

  1. got rid of all other commits in this PR,
  2. brought the branch pd6 in this PR up to date with the most updated master branch, and
  3. modified the Ex1 and its solution according to all our discussions.

Now, this PR is ready to be merged.

jstac commented 4 years ago

Thanks all. Code looks good now. Thanks @shlff for cleaning up the PR at the end.