search

QuantEcon / lecture-source-py

Source files for "Lectures in Quantitative Economics" -- Python version
BSD 3-Clause "New" or "Revised" License
192 stars 77 forks source link

linear_model_issue3 #916

Closed sayaikegawa closed 4 years ago

sayaikegawa commented 4 years ago

Hi @jstac , I removed one of two X_0 in lecture.

shlff commented 4 years ago

Thanks a lot, @sayaikegawa and @jstac .

Good morning, @jstac , as we discussed, in the subsection Time Trends of lecture linear_model, I calculated G = [2a a+b c], added G and kept x_0 = [0 0 1] (as @sayaikegawa did).

You can also see the ipynb file compiled by the rst file of this subsection with these changes, here.

jstac commented 4 years ago

Thanks guys, nice PR.

When I look at the bottom of this display, I feel like the last line should change. Perhaps it should be something like

"You can now confirm that :math:y_t = G x_t has the correct form."

What do you think?

shlff commented 4 years ago

Thanks, @jstac . I think it is a good idea.

Given your advice, I kept all our previous changes and rephrased the last sentence as you instructed. Please see the new ipynb file compiled by the rst file with this new modification, here.

jstac commented 4 years ago

Thanks @shlff and @sayaikegawa --- this is a valuable improvement and a nice, clear PR. Great work.