Closed mtiley closed 4 years ago
Thanks @mtiley
Could one of you please review this @sayaikegawa @Harveyt47 @shlff ?
Thanks @shlff. The RuntimeWarning
was already present before I made any changes (see #903).
I thought it would be best to solve the DeprecationWarning
in a separate PR and as a separate issue while working on the RuntimeWarning
, as the two are not related.
Hi @mtiley , you've fixed the issue of DeprecationWarning
on my end. Cheers.
Thanks @mtiley and @jstac , nice job to solve issue #917 . The code looks nice. Let's solve issue #903 in another PR.