writing_good_code1 - Githubissues

QuantEcon / lecture-source-py

Source files for "Lectures in Quantitative Economics" -- Python version

BSD 3-Clause "New" or "Revised" License

191 stars 77 forks source link

writing_good_code1 #920

Closed sayaikegawa closed 4 years ago

sayaikegawa commented 4 years ago

Hi @jstac , I just fixed variables in the solution because they are different from the exercise asks. (1. The exercise asks when α=0.1, but the code in solution mistakenly sets α=0.12.

The exercise asks changing to γ=1 to 1.25 but the code in solution mistakenly sets α=0.12 again.)

jstac commented 4 years ago

Thanks @sayaikegawa, nice work finding these issues.

If you look at your PR, you will see that 4 files are changed. (Click on Files changed above.) Some of those are not meant to be in this PR. Perhaps it's better to close this PR, make sure you have the latest version of master and then start again?