search

QuantEcon / lecture-source-py

Source files for "Lectures in Quantitative Economics" -- Python version
BSD 3-Clause "New" or "Revised" License
192 stars 77 forks source link

writing_good_code_issue_4 #922

Closed sayaikegawa closed 4 years ago

sayaikegawa commented 4 years ago

Hi @jstac , Thank you for your advice. I recreated PR here. I just fixed variables in the solution because they are different from the exercise asks:

  1. The exercise asks when α=0.1, but the code in solution mistakenly sets α=0.12.
  2. The exercise asks changing from γ=1 to γ=1.25, but the code in solution mistakenly sets α=0.12 again.)
Harveyt47 commented 4 years ago

Hi @sayaikegawa , those changes look good to me. Hi @shlff , I think showing the shift in demand curve on one graph is a nice idea.

jstac commented 4 years ago

Very good job, thanks @sayaikegawa