search

QuantEcon / lecture-source-py

Source files for "Lectures in Quantitative Economics" -- Python version
BSD 3-Clause "New" or "Revised" License
192 stars 77 forks source link

optgrowth_issue #939

Closed Harveyt47 closed 4 years ago

Harveyt47 commented 4 years ago

fix #937

sayaikegawa commented 4 years ago

Thanks @Harveyt47 , that looks good for me.

Harveyt47 commented 4 years ago

Here are the outputs from the change I have made (on the left) to the unchanged lecture (on the right) on the website which will currently have the bug in #937 as version 1.4.1 of scipy (current version) has the bug.

Screenshot from 2020-02-27 11-42-23

Screenshot from 2020-02-27 11-42-32

Screenshot from 2020-02-27 11-42-48

Screenshot from 2020-02-27 11-42-56

Screenshot from 2020-02-27 11-43-05

jstac commented 4 years ago

Great PR @Harveyt47. Please add the ready label when you think it's ready to merge.

mmcky commented 4 years ago

hey @Harveyt47 I have just updated our travis specification for testing. I merged the latest master into this branch to use this PR as a test case for the travis update.

mmcky commented 4 years ago

thanks @Harveyt47 the new travis run shows these all building:

Starting notebook execution for website and html conversion(if set in config)...
1569(1/4)  index -- pass -- 1.12s
1570(2/4)  optgrowth -- pass -- 79.15s
1571(3/4)  index_dynamic_programming_grad -- pass -- 1.03s
1572(4/4)  index_dynamic_programming -- pass -- 0.90s
1573build succeeded, 3 warnings.