search

QuantEcon / lecture-source-py

Source files for "Lectures in Quantitative Economics" -- Python version
BSD 3-Clause "New" or "Revised" License
192 stars 77 forks source link

Sanitize lectures of co-author / co-contributor statements #958

Closed mmcky closed 4 years ago

mmcky commented 4 years ago

remove all co-author statements --- has to be done carefully because the wording varies so it's hard to search.

As part of the transfer to new license we need to check all rst files and remove co-author statements. Presentations are varied so will require going through the first ~10% of each lecture rst file looking for statements like:

pandas_panel.rst contains Most of this lecture was created by Natasha Watkins

This will resolve item 2 in #946

mmcky commented 4 years ago

@sayaikegawa please let me know if you are available to help with this task. Thanks.

sayaikegawa commented 4 years ago

Hi @mmcky , I'm happy to do this.

mmcky commented 4 years ago

thanksk @sayaikegawa

sayaikegawa commented 4 years ago

Hi @mmcky , When I make PR, do you think that it is good idea to remove the names of all lectures's rst file for 1 PR? or removing a name of each rst file for each PR?

mmcky commented 4 years ago

hi @sayaikegawa I think in this case it would be ok to do a single PR that removes them all across the files. I think it is unlikely to cause merge conflicts with other work as they are usually on a single line. If a conflict arises I can help resolve it.

sayaikegawa commented 4 years ago

Thank you @mmcky , then I will make a single PR.

sayaikegawa commented 4 years ago

Hi @jstac and @mmcky , would it be ok to remove author of lectures and codes like below as well? And should I wait making PR until the split finishes? Screen Shot 2020-03-10 at 12 51 42 pm Screen Shot 2020-03-10 at 12 52 18 pm

mmcky commented 4 years ago

would it be ok to remove author of lectures and codes like below as well?

hi @sayaikegawa good question. I think removal of all names (code and rst) is the way to go. Good find.

And should I wait making PR until the split finishes?

how far along are you? Feel free to keep going on this task as I can merge in the changes to the split repositories later on.

sayaikegawa commented 4 years ago

Thank you @mmcky , I think I can finish this by tomorrow evening at the latest.

jstac commented 4 years ago

Thanks @sayaikegawa. Names are to be removed everywhere, as @mmcky says.

By the way, could you please keep a list of the names that you remove? Then we can try to make sure that these people are recognized for their contribution in some way.

sayaikegawa commented 4 years ago

Thank you @jstac . I'll make the list.