Open jstac opened 6 months ago
I ll add a modified version of John s sentence. Not all variables are constant though. The art is to spot which variables are invariant. This relates to eigen functions. Good suggestion John.
On Mon, Feb 19, 2024, 2:58 AM John Stachurski @.***> wrote:
This is a fascinating lecture and I imagine it's going to be very useful for undergraduate macro. I think it's suitable for the introductory lecture series, even though it's more advanced than most.
It highlights the almost magical way that the eigenvector decomposition can be used to decouple linear systems.
Minor suggestions:
- After the sentence "But first it is instructive to describe a special type of equilibrium known as a steady state." it might be worth adding "A steady state is an equilibrium where all variables are constant over time."
- In remark 2, "An equilibrium" -> "Equilibrium"
Once it's embedded in a lecture series, we should add links to related lectures.
@HumphreyYang https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_HumphreyYang&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hV4qLWg4zodvX-YQ-ETIbA&m=XnVGCaYw2fdybhT0u99Q3iYho7Bwqtoa2-ixfLB9sAH8S86j4ni22_MZWuppVaU3&s=k2RUMtH3K8ovCpCDGTaJsSkQ2WYjRB4og0AzF4panls&e= I notice that you include plt.rcParams['figure.dpi'] = 300 or similar in some lectures, such as this one. At the same time, there's nothing very special about the figures in this lecture. That suggests to me that either we don't need this line (we should try to minimize distracting code at the start) or it should be embedded in the defaults and thus hidden from the reader. @mmcky https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mmcky&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hV4qLWg4zodvX-YQ-ETIbA&m=XnVGCaYw2fdybhT0u99Q3iYho7Bwqtoa2-ixfLB9sAH8S86j4ni22_MZWuppVaU3&s=6zRyoB42ga_W-f_DTxvvfWRtUqK4aaKQ74TQAqSbv60&e=, perhaps you could sort this out with @HumphreyYang https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_HumphreyYang&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hV4qLWg4zodvX-YQ-ETIbA&m=XnVGCaYw2fdybhT0u99Q3iYho7Bwqtoa2-ixfLB9sAH8S86j4ni22_MZWuppVaU3&s=k2RUMtH3K8ovCpCDGTaJsSkQ2WYjRB4og0AzF4panls&e= ?
— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_QuantEcon_python-2Dlecture-2Dsandpit.myst_issues_17&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hV4qLWg4zodvX-YQ-ETIbA&m=XnVGCaYw2fdybhT0u99Q3iYho7Bwqtoa2-ixfLB9sAH8S86j4ni22_MZWuppVaU3&s=21zZuKHDQVf-DqBetPqUAkpeDm0nK1O0Av8J6UjvhU0&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AA63MTSAONX25PVLUHU6EYLYUJFLNAVCNFSM6AAAAABDOLW2N2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DCMJTG44TKMA&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hV4qLWg4zodvX-YQ-ETIbA&m=XnVGCaYw2fdybhT0u99Q3iYho7Bwqtoa2-ixfLB9sAH8S86j4ni22_MZWuppVaU3&s=X4Pllonglny-nqHHHCXL6SD88dI9ztmEqCmxp7lC1ks&e= . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi @jstac,
Many thanks for your feedback.
I notice that you include
plt.rcParams['figure.dpi'] = 300
This line increases the pixel density of the plot. This will increase the sharpness of the plots to avoid blurry images under default dpi, especially when there are text annotations.
I think we might be able to include this as a global parameter like the image size in the config file.
This line increases the pixel density of the plot. This will increase the sharpness of the plots to avoid blurry images under default dpi, especially when there are text annotations.
Thanks @HumphreyYang , I understand that, and what you say is important. I appreciate your attention to quality.
My point is there's nothing very special about these figures, which suggests that either it should be a global config or we shouldn't be using it.
I think we might be able to include this as a global parameter like the image size in the config file.
That's my preference too. CC @mmcky
My point is there's nothing very special about these figures, which suggests that either it should be a global config or we shouldn't be using it.
If the default quality isn't good enough for some reason, the dpi
setting can't be given to matplotlib
in the global
config (unless we use machine level config rc
files for matplotlib).
What we have been doing to date (in the case where th quality needs to be posted is to use)
fig, ax = plt.subplots(dpi=200)
when setting up the figure.
I think that is a lot less confusing that the dreaded rcparams
at the top -- I agree with @jstac.
Next steps would be:
rcparams
to see if the quality is good enoughDo you agree @jstac
This is a fascinating lecture and I imagine it's going to be very useful for undergraduate macro. I think it's suitable for the introductory lecture series, even though it's more advanced than most.
It highlights the almost magical way that the eigenvector decomposition can be used to decouple linear systems.
Minor suggestions:
Once it's embedded in a lecture series, we should add links to related lectures.
@HumphreyYang I notice that you include
plt.rcParams['figure.dpi'] = 300
or similar in some lectures, such as this one. At the same time, there's nothing very special about the figures in this lecture. That suggests to me that either we don't need this line (we should try to minimize distracting code at the start) or it should be embedded in the defaults and thus hidden from the reader. @mmcky, perhaps you could sort this out with @HumphreyYang ?