QuantEcon / quantecon-book-theme

A Jupyter Book Theme for QuantEcon Book Style Projects
BSD 3-Clause "New" or "Revised" License
40 stars 20 forks source link

🐛 FIX: Right side navbar fix #111

Closed AakashGfude closed 3 years ago

AakashGfude commented 3 years ago

RIght navbar went missing with the quantecon-book-theme 0.1.6 release, this PR fixes it. The default navbar HTML inherited from pydata-sphinx-theme also has numbering of the sections included. (when numbered:true)

Screen Shot 2021-05-03 at 10 27 45 am

fixes https://github.com/QuantEcon/quantecon-book-theme/issues/110

codecov[bot] commented 3 years ago

Codecov Report

Merging #111 (9d0e399) into master (813dead) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files           2        2           
  Lines         227      227           
=======================================
  Hits          166      166           
  Misses         61       61           
Flag Coverage Δ
pytests 73.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 813dead...9d0e399. Read the comment docs.

mmcky commented 3 years ago

thanks @AakashGfude for prioritising this. Looks great. Please go ahead and merge when you're ready and issue a new release -- then I will retest on python.quantecon.org PR