QuantEcon / quantecon-book-theme

A Jupyter Book Theme for QuantEcon Book Style Projects
BSD 3-Clause "New" or "Revised" License
41 stars 21 forks source link

πŸ‘Œ IMPROVE: Refactoring and upgrading #115

Closed AakashGfude closed 3 years ago

AakashGfude commented 3 years ago

The following PR is a refactor with the following improvements/features

codecov[bot] commented 3 years ago

Codecov Report

Merging #115 (27d12f4) into master (907074e) will decrease coverage by 1.47%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   73.12%   71.64%   -1.48%     
==========================================
  Files           2        2              
  Lines         227      194      -33     
==========================================
- Hits          166      139      -27     
+ Misses         61       55       -6     
Flag Coverage Ξ”
pytests 71.64% <50.00%> (-1.48%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
quantecon_book_theme/__init__.py 65.56% <50.00%> (-2.92%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 907074e...27d12f4. Read the comment docs.

mmcky commented 3 years ago

thanks @AakashGfude ping me as a reviewer when this is ready for a review.

mmcky commented 3 years ago

Adding some test PR's

mmcky commented 3 years ago

@AakashGfude a number of styles still need to be migrated.

Screen Shot 2021-05-04 at 1 14 19 pm Screen Shot 2021-05-04 at 1 16 06 pm
AakashGfude commented 3 years ago

@mmcky , the above point in the netlify link looks fine in chrome, are you in safari?

Screen Shot 2021-05-04 at 1 56 28 pm
mmcky commented 3 years ago

@mmcky , the above point in the netlify link looks fine in chrome, are you in safari?

Screen Shot 2021-05-04 at 1 56 28 pm

Yeah I am using safari

@AakashGfude some additional info. If I change the math rendering settings from CHTML to SVG they show up ok in safari. What is CHTML?

Maybe we should use tex-mml-svg or something like that for compatibility?

<script async="async" src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js"></script>

https://docs.mathjax.org/en/latest/web/components/combined.html

mmcky commented 3 years ago

nice work on the javascript fix @AakashGfude

https://6090cb92937c549956e4e108--wonderful-lalande-528d1c.netlify.app/matsuyama.html#interactive-version

I will need to add a note that it isn't connected to a running kernel but this is looking neat.

AakashGfude commented 3 years ago

I will need to add a note that it isn't connected to a running kernel but this is looking neat.

true. it is not working for sphinx-book-theme as well. so we might need to target it on the parent package it seems.

mmcky commented 3 years ago

@AakashGfude this is looking good on the rebuilds.

I found one small instance of that incomplete font issue. It looks like it is using chtml still as the default. I could only find it in one place but I will keep an eye out for that issue.

You happy to merge this and then update #100 and #93

mmcky commented 3 years ago

@AakashGfude this is the case I am finding the issue still with the fonts in linear algebra of lecture-python.myst

Screen Shot 2021-05-05 at 12 51 18 pm
AakashGfude commented 3 years ago

@mmcky merging this one.πŸš€