Closed AakashGfude closed 3 years ago
Merging #115 (27d12f4) into master (907074e) will decrease coverage by
1.47%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 73.12% 71.64% -1.48%
==========================================
Files 2 2
Lines 227 194 -33
==========================================
- Hits 166 139 -27
+ Misses 61 55 -6
Flag | Coverage Ξ | |
---|---|---|
pytests | 71.64% <50.00%> (-1.48%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Ξ | |
---|---|---|
quantecon_book_theme/__init__.py | 65.56% <50.00%> (-2.92%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 907074e...27d12f4. Read the comment docs.
thanks @AakashGfude ping me as a reviewer when this is ready for a review.
Adding some test PR's
@AakashGfude a number of styles still need to be migrated.
centered
by defaultinline
math is not showing correctly such as the following in linear algebra section
- [ ] some
inline
math is not showing correctly such as the following in linear algebra section
@mmcky , the above point in the netlify link looks fine in chrome, are you in safari?
- [ ] some
inline
math is not showing correctly such as the following in linear algebra section@mmcky , the above point in the netlify link looks fine in chrome, are you in safari?
Yeah I am using safari
@AakashGfude some additional info. If I change the math
rendering settings from CHTML
to SVG
they show up ok in safari
. What is CHTML
?
Maybe we should use tex-mml-svg
or something like that for compatibility?
<script async="async" src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js"></script>
https://docs.mathjax.org/en/latest/web/components/combined.html
nice work on the javascript
fix @AakashGfude
I will need to add a note that it isn't connected to a running kernel but this is looking neat.
I will need to add a note that it isn't connected to a running kernel but this is looking neat.
true. it is not working for sphinx-book-theme as well. so we might need to target it on the parent package it seems.
@AakashGfude this is looking good on the rebuilds.
I found one small instance of that incomplete font issue. It looks like it is using chtml
still as the default. I could only find it in one place but I will keep an eye out for that issue.
You happy to merge this and then update #100 and #93
@AakashGfude this is the case I am finding the issue still with the fonts in linear algebra
of lecture-python.myst
@mmcky merging this one.π
The following PR is a refactor with the following improvements/features
interact
feature of ipywidgets work with mathjax