QuantEcon / quantecon-book-theme

A Jupyter Book Theme for QuantEcon Book Style Projects
BSD 3-Clause "New" or "Revised" License
41 stars 21 forks source link

✨ NEW: private input field for jupyterlab #129

Closed AakashGfude closed 3 years ago

AakashGfude commented 3 years ago

UPDATE : Description is updated after merging @DrDrij 's work in this PR: https://github.com/QuantEcon/quantecon-book-theme/pull/130

A private input field for hosting notebooks, the server can only be of jupyterlab at present :

Screen Shot 2021-05-28 at 4 54 41 pm

example of a URL formed at the moment is:-

https://pims.syzygy.ca/jupyter/hub/user-redirect/git-pull?repo=https://github.com/QuantEcon/lecture-datascience.notebooks&urlpath=tree/lecture-datascience.notebooks/scientific/numpy_arrays.ipynbscientific/numpy_arrays.ipynb

when in the private window, the value entered is https://pims.syzygy.ca

When the private window is empty, the launch notebook button turns grey and inactive:

Screen Shot 2021-05-28 at 4 57 28 pm
codecov[bot] commented 3 years ago

Codecov Report

Merging #129 (fb8fa0a) into master (305ec75) will increase coverage by 0.55%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   71.73%   72.29%   +0.55%     
==========================================
  Files           2        2              
  Lines         230      231       +1     
==========================================
+ Hits          165      167       +2     
+ Misses         65       64       -1     
Flag Coverage Δ
pytests 72.29% <100.00%> (+0.55%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quantecon_book_theme/launch.py 90.69% <100.00%> (+1.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 305ec75...fb8fa0a. Read the comment docs.

mmcky commented 3 years ago

thanks @AakashGfude.

@DrDrij do you want to merge this into your work on combining these buttons together for execution environments? I'll let you manage if you want this merged before or after your work here.