ENH: Adding Search - Githubissues

QuantEcon / quantecon-book-theme

A Jupyter Book Theme for QuantEcon Book Style Projects

BSD 3-Clause "New" or "Revised" License

40 stars 20 forks source link

ENH: Adding Search #204

Closed AakashGfude closed 1 year ago

AakashGfude commented 1 year ago

Adding a search button:

Which expands to a search input on clicking:

And the search result page:

codecov[bot] commented 1 year ago

Codecov Report

Merging #204 (cf18170) into master (b7d02c4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files           2        2           
  Lines         239      239           
=======================================
  Hits          170      170           
  Misses         69       69

Flag	Coverage Δ
pytests	`71.12% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mmcky commented 1 year ago

thanks @AakashGfude this is looking great -- I like the simple search icon.

Some comments and ideas:

[x] I think it should be located to the right in the same cluster as the font adjustment, brightness etc.
[x] once you click on search I think the field should enlarge to be bigger that the current size and incorporate curved or softened corners

@DrDrij would you mind to give @AakashGfude some help in making this a bit more integrated to the site.

mmcky commented 1 year ago

@jstac this PR is adding search and was interested in your ideas as well

The demo page:

https://644f3f4291193548b40d375c--hungry-lovelace-7d0512.netlify.app/intro.html

and a search result

https://644f3f4291193548b40d375c--hungry-lovelace-7d0512.netlify.app/search.html?q=matplotlib

AakashGfude commented 1 year ago

@mmcky does this look better? Or a bigger search field?