QuantEcon / quantecon-book-theme

A Jupyter Book Theme for QuantEcon Book Style Projects
BSD 3-Clause "New" or "Revised" License
40 stars 20 forks source link

FIX: Dark theme styling fixes #228

Closed AakashGfude closed 11 months ago

AakashGfude commented 11 months ago

fixes #227

The screenshot of fixes are (ordering based on issue #227 ):

1)

Screen Shot 2023-10-05 at 3 35 07 pm

2)

Screen Shot 2023-10-05 at 4 05 29 pm

3) I feel the images look better this way in dark mode. If the background is white, its too bright and defeats the purpose of dark-theme. What do you think @mmcky @HumphreyYang

Screen Shot 2023-10-05 at 4 05 54 pm

4)

Screen Shot 2023-10-05 at 4 06 13 pm

5)

Screen Shot 2023-10-05 at 4 06 41 pm

cc: @HumphreyYang @mmcky

codecov[bot] commented 11 months ago

Codecov Report

Merging #228 (3db47b5) into master (3241d53) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files           2        2           
  Lines         261      261           
=======================================
  Hits          191      191           
  Misses         70       70           
Flag Coverage Δ
pytests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

HumphreyYang commented 11 months ago

Many thanks @AakashGfude, this looks even better!

I feel the images look better this way in dark mode. If the background is white, its too bright and defeats the purpose of dark-theme. What do you think @mmcky @HumphreyYang

The one in the screenshot looks great to me!


I am also curious if we need a new QuantEcon logo for dark mode:

Screenshot 2023-10-06 at 09 41 10

Perhaps with white text?

I also spotted some images without being in the dark mode in this lecture


There are small edge cases for the top right buttons:

  1. The text colour for the launch methods is slightly too close to the background:

    Screenshot 2023-10-06 at 09 44 46
  2. I distantly remember the "Download PDF" button would take us to the PDF build of this lecture before instead of calling the print function of the browser (please correct me if I were wrong):

    Screenshot 2023-10-06 at 09 44 55

One small question about styling I have is whether we want to show code output slightly more different from code cells:

In light mode, we have very distinctive cells and outputs:

Screenshot 2023-10-06 at 09 52 18

but it looks very similar in dark mode:

Screenshot 2023-10-06 at 09 52 13

Hope this helps : )

AakashGfude commented 11 months ago

Thanks @HumphreyYang , I think we will have to create a new image for that.

  1. Have done the text method for the launch

    Screen Shot 2023-10-10 at 2 37 43 pm
  2. "Download PDF" does print for single page, and our own compiled pdf for books. The books one is available only when a build has been run and included. Which is not done here.

  3. This should be okay?

    Screen Shot 2023-10-10 at 2 38 07 pm
HumphreyYang commented 11 months ago

Thanks @HumphreyYang , I think we will have to create a new image for that.

  1. Have done the text method for the launch

Screen Shot 2023-10-10 at 2 37 43 pm 2. "Download PDF" does print for single page, and our own compiled pdf for books. The books one is available only when a build has been run and included. Which is not done here.

  1. This should be okay?
Screen Shot 2023-10-10 at 2 38 07 pm

Many thanks @AakashGfude, these look great to me!