Closed AakashGfude closed 11 months ago
Merging #228 (3db47b5) into master (3241d53) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 73.18% 73.18%
=======================================
Files 2 2
Lines 261 261
=======================================
Hits 191 191
Misses 70 70
Flag | Coverage Δ | |
---|---|---|
pytests | 73.18% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Many thanks @AakashGfude, this looks even better!
I feel the images look better this way in dark mode. If the background is white, its too bright and defeats the purpose of dark-theme. What do you think @mmcky @HumphreyYang
The one in the screenshot looks great to me!
I am also curious if we need a new QuantEcon logo for dark mode:
Perhaps with white text?
I also spotted some images without being in the dark mode in this lecture
There are small edge cases for the top right buttons:
The text colour for the launch methods is slightly too close to the background:
I distantly remember the "Download PDF" button would take us to the PDF build of this lecture before instead of calling the print function of the browser (please correct me if I were wrong):
One small question about styling I have is whether we want to show code output slightly more different from code cells:
In light mode, we have very distinctive cells and outputs:
but it looks very similar in dark mode:
Hope this helps : )
Thanks @HumphreyYang , I think we will have to create a new image for that.
Have done the text method for the launch
"Download PDF" does print for single page, and our own compiled pdf for books. The books one is available only when a build has been run and included. Which is not done here.
This should be okay?
Thanks @HumphreyYang , I think we will have to create a new image for that.
- Have done the text method for the launch
2. "Download PDF" does print for single page, and our own compiled pdf for books. The books one is available only when a build has been run and included. Which is not done here.
- This should be okay?
Many thanks @AakashGfude, these look great to me!
fixes #227
The screenshot of fixes are (ordering based on issue #227 ):
1)
2)
3) I feel the images look better this way in dark mode. If the background is white, its too bright and defeats the purpose of dark-theme. What do you think @mmcky @HumphreyYang
4)
5)
cc: @HumphreyYang @mmcky