Address suggestions to GDP lecture

Jiarui-ZH commented 6 months ago

This update addresses the comments and suggestions made in #26 for my sections.

General

[x] Only the first letter and proper nouns should be capitalized in graph labels and chapter titles.
[x] Use graph captions in myst instead of title in matplotlib
[ ] Section numbers can be removed
[ ] Data sources can be included in the caption (This is related to the second comment in this section above).

[x] Remove capitalization of 'Real' and 'Nominal' GDP in the sentence.
[x] Chained dollar is not properly introduced -- and it might be too advanced for an introductory lecture.
[x] The line 'Source: Federal Reserve Economic Data (St. Louis Fed)' can be put into the caption of the figure.
[x] Remove wb.series.info(q='GDP') as it is not used.
[ ] In ## 1.3 GDP: Ways of Calculation, introduce only one way of GDP calculation (perhaps value added method) and refer readers to other methods using links.

[ ] In the line,

pd.read_excel('Global temp.xlsx', sheet_name='Temperature Anomaly')

'Global temp.xlsx' is not found.

HumphreyYang commented 6 months ago

Many thanks @Jiarui-ZH,

Could you pleaase migrate your change to gdp_intro.md?

I think the markdown you are working on is outdated.

Jiarui-ZH commented 6 months ago

Apologies for the confusion, please see the latest PR

HumphreyYang commented 6 months ago

Many thanks @Jiarui-ZH.

Please make sure that other changes are reverted (try cherry-picking in git -- it is sometimes a bad function but fun to use).