search

QuantEcon / sphinxcontrib-jupyter

A Sphinx Extension for Generating Jupyter Notebooks
BSD 3-Clause "New" or "Revised" License
76 stars 23 forks source link

BUG: Fix mixed numbered and bullet lists #143

Open mmcky opened 5 years ago

mmcky commented 5 years ago

Currently mixed lists are not working with numbers and bullets (sublists)

1. bla
  * foo1
  * foo 2
2. bla2
  * foo
3. bla3

the current output interprets the bullet lists as blockquotes

1. bla  

> - foo1  
- foo 2  

1. bla2  

> - foo  

1. bla3

thanks @jlperla for reporting.

mmcky commented 5 years ago

Current sphinx warnings

/home/mmcky/repos-collab/sphinxcontrib-jupyter/tests/lists.rst:68: WARNING: Enumerated list ends without a blank line; unexpected unindent.
/home/mmcky/repos-collab/sphinxcontrib-jupyter/tests/lists.rst:70: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/mmcky/repos-collab/sphinxcontrib-jupyter/tests/lists.rst:71: WARNING: Enumerated list ends without a blank line; unexpected unindent.
/home/mmcky/repos-collab/sphinxcontrib-jupyter/tests/lists.rst:72: WARNING: Block quote ends without a blank line; unexpected unindent.
arnavs commented 5 years ago

@mmcky I think this is OK now? See "setting up your Julia environment" in http://compare-lectures.quantecon.org/jl/getting_started.html

mmcky commented 5 years ago

@arnavs can you confirm if these are fixed on your end?

mmcky commented 5 years ago

the test case is still not rendering properly. But it is working well in the lecture.

mmcky commented 5 years ago

see https://github.com/QuantEcon/sphinxcontrib-jupyter/pull/145 for details.

Keeping open but adding wontfix label for now

mmcky commented 5 years ago

@arnavs is this still an issue?