added a check for code blocks when escaping

QuantEcon / sphinxcontrib-jupyter

A Sphinx Extension for Generating Jupyter Notebooks

BSD 3-Clause "New" or "Revised" License

76 stars 23 forks source link

added a check for code blocks when escaping #175

Closed AakashGfude closed 5 years ago

AakashGfude commented 5 years ago

This PR is just preventing the escaping of $ when it is a code block. Solves the issue #173 . But have not tested the consequences it might have otherwise. I reckon we dont need escaping in any of the code blocks right? @arnavs @jlperla @mmcky

fixes #173

jlperla commented 5 years ago

Thanks! I will let @arnavs Do the verification.

arnavs commented 5 years ago

Thanks @AakashGfude, will take a look at this tomorrow. But I think you're right --- inside code blocks things should be verbatim.

arnavs commented 5 years ago

Can confirm that this PR resolves errors with Julia lectures. Looking at datascience now.

arnavs commented 5 years ago

OK, this looks good. It fixes the Julia without altering the output on the datascience (that output won't be perfect, yet, because the source would still have all sorts of hacky escapes). So this means that the code blocks are being properly excluded.

@AakashGfude, whenever you're in front of a keyboard, merge away!