DISC: review option jupyter_static_file_path

QuantEcon / sphinxcontrib-jupyter

A Sphinx Extension for Generating Jupyter Notebooks

BSD 3-Clause "New" or "Revised" License

76 stars 23 forks source link

DISC: review option jupyter_static_file_path #198

Closed mmcky closed 5 years ago

mmcky commented 5 years ago

jupyter_static_file_path is currently implemented as a list. Should this just be a string?

app.add_config_value("jupyter_static_file_path", [], "jupyter")

Is there a benefit to using a list? Is this just done to concatenate easily?

AakashGfude commented 5 years ago

Probably this was implemented as a list to allow multiple static folders to exist and their files being used. We don't have any requirement as such at present, so maybe we can change it to be a string? @mmcky

mmcky commented 5 years ago

this mimics the html_static option so I think we should leave this as is. Closing.