FIX: Fix various defaults for config options and improve BUILDDIR targeting to be specified in Makefile

QuantEcon / sphinxcontrib-jupyter

A Sphinx Extension for Generating Jupyter Notebooks

BSD 3-Clause "New" or "Revised" License

76 stars 23 forks source link

FIX: Fix various defaults for config options and improve BUILDDIR targeting to be specified in Makefile #207

Closed mmcky closed 5 years ago

mmcky commented 5 years ago

This PR:

changes the default values of config variables which are strings to use None instead of False or "" for consistency and to remove sphinx warnings
remove hard coded target build_dir references in favour of being able to specify through Makefile BUILDDIR settings.

mmcky commented 5 years ago

[x] @AakashGfude we will need to review the testing setup here as the conf.py and make website have diverged from how lectures-source-py will be setup. Testing this extension should be done against the three pipelines make jupyter, make website, and make coverage

AakashGfude commented 5 years ago

The latest two commits, remove hardcoding of directory paths from the sphinxcontrib code and instead uses directory names specified in the makefile to create files and folders.